I need a code review pls

HTML & CSS
,
1

This is my first solo project ever btw
Solo Project (PRO) - The Daily Dribble Newsletter

2

Good job @shiraaxd ! Here are some improvements to further refine what you’ve built:

Avoid using class on semantic elements redundantly

<div class="h1">
    <h1>THE DAILY DRIBBLE</h1>
</div>

The div with class h1 is unnecessary. Instead, apply styles directly to the <h1> in your CSS:

HTML
<h1>THE DAILY DRIBBLE</h1>

CSS

h1 {
    text-align: center;
    font-size: 32px; /* or your preferred size */
}

Add Spacing and Grouping
Consider adding some spacing between sections using padding or margins to make it feel more breathable. For example:

.content {
    margin-top: 20px;
    margin-bottom: 20px;
}

Make It Mobile-Responsive

The fixed width of 380px on .content and the image may look squeezed on small screens. Use relative widths like percentages or max-widths:

.content, img {
    max-width: 90%;
    width: 380px;
}

Fix the Broken Link
This anchor tag:
<a href=# target="_blank">terms of service</a>

Should always have quotes around the URL, even if it’s a placeholder:
<a href="#" target="_blank">terms of service</a>

Hope that helps!

1 Like